Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Size 'large' vs 'lg' #4093

Closed
EduardoCastanho opened this issue Feb 22, 2023 · 1 comment · Fixed by #4094 or #4121
Closed

Button: Size 'large' vs 'lg' #4093

EduardoCastanho opened this issue Feb 22, 2023 · 1 comment · Fixed by #4094 or #4121
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
9.2.1

Comments

@EduardoCastanho
Copy link

Describe the bug

hi

For defining the Button size the docs state we should use size="large"|"small"

but doesn't work

checking the code :

primereact/components/lib/button/Button.js

Line 65 in c5ef16d

[`p-button-${props.size}`]: props.size,

The attribute size is transformed in a class for css
but nowhere to be found the corresponding class ' p-button-large' in themes css files
but we can find in all themes the class 'p-button-lg'

for example:

primereact/public/themes/nova-accent/theme.css

Line 1888 in c5ef16d

.p-button.p-button-lg {

can you check this ?

Reproducer

No response

PrimeReact version

9.20

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

firefox

Steps to reproduce the behavior

No response

Expected behavior

No response
@EduardoCastanho EduardoCastanho added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 22, 2023
@melloware melloware added Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 23, 2023
@melloware
Copy link
Member

Yep the Typescript and docs are wrong. I will submit a PR.

@melloware melloware added Component: Documentation Issue or pull request is related to Documentation Typescript Issue or pull request is *only* related to TypeScript definition and removed Component: Theme Issue or pull request is related to Theme labels Feb 23, 2023
@melloware melloware self-assigned this Feb 23, 2023
@melloware melloware added this to the 9.2.1 milestone Feb 23, 2023
melloware added a commit to melloware/primereact that referenced this issue Feb 23, 2023
@melloware
Fix primefaces#4093: Button size docs corrected
51074a6
@melloware melloware mentioned this issue Feb 23, 2023
Merged
habubey added a commit that referenced this issue Mar 2, 2023
@habubey
Merge pull request #4094 from melloware/PR4093
81b6936 
Fix #4093: Button size docs corrected
@mertsincan mertsincan reopened this Mar 2, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 2, 2023
@ulasturann ulasturann linked a pull request Mar 2, 2023 that will close this issue
Fix #4093: Button: Size 'large' or 'lg' #4121
Merged
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 2, 2023
mertsincan pushed a commit that referenced this issue Mar 3, 2023
@ulasturann
Fix #4093: Button: Size 'large' or 'lg' (#4121)
ce30f90 
* Fix #4093: Button: Size 'large' or 'lg'

* Update API doc

---------

Co-authored-by: GitHub Actions Bot <>
@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Component: Documentation Issue or pull request is related to Documentation labels Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
9.2.1
Development

Successfully merging a pull request may close this issue.

Fix #4093: Button size docs corrected melloware/primereact
Fix #4093: Button: Size 'large' or 'lg'
3 participants
@melloware @EduardoCastanho @mertsincan