Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: selectionLimit ux enhancement #4784

Closed
lenard-a opened this issue Aug 15, 2023 · 1 comment · Fixed by #4795
Closed

Autocomplete: selectionLimit ux enhancement #4784

lenard-a opened this issue Aug 15, 2023 · 1 comment · Fixed by #4795
Assignees
@melloware
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
10.0.0

Comments

@lenard-a
Copy link

lenard-a commented Aug 15, 2023 •
edited
Loading

Describe the feature you would like to see added

If a selectionLimit is set and reached:

  • hide placeholder
  • prevent user to type new search string and trigger the completeMethod

(Currently the placeholder is displayed, user can type and select a match, but then it is not added due to the selectionLimit. It does not make sense to let them proceed)
@lenard-a lenard-a added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Aug 15, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 15, 2023
@melloware
Copy link
Member

Good suggestion

@melloware melloware added this to the 10.0.0 milestone Aug 15, 2023
@melloware melloware removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 17, 2023
@melloware melloware self-assigned this Aug 17, 2023
melloware added a commit to melloware/primereact that referenced this issue Aug 17, 2023
@melloware
Fix primefaces#4784: AutoComplete improve UX with selectionLimit
7ba229b
@melloware melloware mentioned this issue Aug 17, 2023
Merged
melloware added a commit that referenced this issue Aug 17, 2023
@melloware
Fix #4784: AutoComplete improve UX with selectionLimit (#4795)
db55201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4784: AutoComplete improve UX with selectionLimit melloware/primereact
2 participants
@melloware @lenard-a