-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataTable: conditional row reorder shows "false" instead of hiding reorder icon #4854
Labels
Resolution: Workaround
Issue or pull request contains a workaround. It needs to be reviewed further by Core Team
Type: Bug
Issue contains a defect related to a specific component.
Milestone
Comments
gonzaloarca
added
the
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
label
Aug 31, 2023
Can you add a repro link (sandbox) to the issue? @gonzaloarca |
@akshayantony55 done |
To get rid of showRowReorderElement={(data) => data.showReorder ? data.showReorder : ""} |
melloware
added
Resolution: Workaround
Issue or pull request contains a workaround. It needs to be reviewed further by Core Team
Type: Bug
Issue contains a defect related to a specific component.
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Sep 1, 2023
melloware
added a commit
to melloware/primereact
that referenced
this issue
Sep 1, 2023
melloware
added a commit
that referenced
this issue
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Resolution: Workaround
Issue or pull request contains a workaround. It needs to be reviewed further by Core Team
Type: Bug
Issue contains a defect related to a specific component.
Describe the bug
I'm attempting to use the
showRowReorderElement
prop in the DataTable component, and in those cases where the RowReorderElement should be hiding, it renders afalse
text instead.On a side note, is it possible to provide a fallback component for the column in those cases where the
showRowReorderElement
function evaluates to false?Here's an image of what the rendered table looks like in the aforementioned column.
Reproducer
CodeSandbox
PrimeReact version
9.6.0
React version
17.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
showRowReorderElement
function, and a column with the rowReorder prop set to trueExpected behavior
I expected the row that makes the
showRowReorderElement
evaluate to false to be hidden, instead of renderingfalse
The text was updated successfully, but these errors were encountered: