Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar determinate type doesnt apply classNames passed through props #5003

Closed
Kimblis opened this issue Oct 2, 2023 · 2 comments · Fixed by #5006
Closed

Progress bar determinate type doesnt apply classNames passed through props #5003

Kimblis opened this issue Oct 2, 2023 · 2 comments · Fixed by #5006
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.3

Comments

@Kimblis
Copy link

Kimblis commented Oct 2, 2023

Describe the bug

You can also se in the code you apply className passed through props to indeterminate type progressbar but don't pass it to determinate, it worked before, fcked it up with new versions.
image

Reproducer

No response

PrimeReact version

10.0.2

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome

Steps to reproduce the behavior

Add progress bar

Expected behavior

Should apply classnames
@Kimblis Kimblis added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 2, 2023
@Kimblis
Copy link
Author

Kimblis commented Oct 2, 2023

66dda8d this commit left this bug so can clearly see the way to fix it

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 2, 2023
@melloware melloware self-assigned this Oct 2, 2023
@melloware melloware added this to the 10.0.3 milestone Oct 2, 2023
melloware added a commit to melloware/primereact that referenced this issue Oct 2, 2023
@melloware
Fix primefaces#5003: ProgressBar apply classname to determinate
76c37bd
@melloware melloware mentioned this issue Oct 2, 2023
Merged
@melloware
Copy link
Member

PR submitted. Thanks for reporting!

melloware added a commit that referenced this issue Oct 2, 2023
@melloware
Fix #5003: ProgressBar apply classname to determinate (#5006)
dd9e906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.3
Development

Successfully merging a pull request may close this issue.

Fix #5003: ProgressBar apply classname to determinate melloware/primereact
2 participants
@melloware @Kimblis