Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwind: Dialog - mask: modal property is undefined #5296

Closed
Dalorzo opened this issue Nov 13, 2023 · 0 comments · Fixed by #5305
Closed

Tailwind: Dialog - mask: modal property is undefined #5296

Dalorzo opened this issue Nov 13, 2023 · 0 comments · Fixed by #5305
Assignees
@melloware
Labels
Component: Tailwind Tailwind specific issue
Milestone
10.1.0

Comments

@Dalorzo
Copy link
Contributor

Dalorzo commented Nov 13, 2023 •
edited
Loading

Describe the bug

Tailwind: Dialog - mask: modal property is undefined

Under the mask function for tailwind, modal is always undefined.

    mask: (props: TailwindDialogDialogProps) => ({
      className: classNames('transition duration-200 bg-black/40', {
        'bg-black/40': props.modal === true,
      }),
    }),

Reproducer

No response

PrimeReact version

10.0.9

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Dalorzo Dalorzo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 13, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 13, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 13, 2023
@melloware
Fix primefaces#5296: Tailwind dialog mask props
6863cff
@melloware melloware self-assigned this Nov 13, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 13, 2023
@melloware melloware mentioned this issue Nov 13, 2023
Merged
nitrogenous added a commit that referenced this issue Nov 13, 2023
@nitrogenous
Merge pull request #5305 from melloware/PR5296
c270c51 
Fix #5296: Tailwind dialog mask props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Milestone
10.1.0
Development

Successfully merging a pull request may close this issue.

Fix #5296: Tailwind dialog mask props melloware/primereact
2 participants
@melloware @Dalorzo