Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabMenu: activeIndex not rerendering tabs with Tailwind #5457

Closed
sdwillbrand opened this issue Nov 30, 2023 · 3 comments · Fixed by #5458 or #5703
Closed

TabMenu: activeIndex not rerendering tabs with Tailwind #5457

sdwillbrand opened this issue Nov 30, 2023 · 3 comments · Fixed by #5458 or #5703
Assignees
@melloware
Labels
Component: Tailwind Tailwind specific issue
Milestone
10.3.1

Comments

@sdwillbrand
Copy link
Contributor

sdwillbrand commented Nov 30, 2023 •
edited
Loading

Describe the bug

TabMenu does not change the new tab when activeIndex is changed.

Reproducer

https://codesandbox.io/p/sandbox/floral-dew-h9kdfq

PrimeReact version

10.2.1

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome, Safari

Steps to reproduce the behavior

  1. Click on a new tab

Expected behavior

New tab is highlighted.
@sdwillbrand sdwillbrand added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 30, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 30, 2023
@melloware
Copy link
Member

I think I need to make a similar fix to this: #5445

melloware added a commit to melloware/primereact that referenced this issue Nov 30, 2023
@melloware
Fix primefaces#5457: TabMenu fix tailwind styling
b6258a5
@melloware melloware self-assigned this Nov 30, 2023
@melloware melloware added this to the 10.2.2 milestone Nov 30, 2023
@melloware melloware mentioned this issue Nov 30, 2023
Merged
melloware added a commit that referenced this issue Nov 30, 2023
@melloware
Fix #5457: TabMenu fix tailwind styling (#5458)
ad61ccf
@sdwillbrand
Copy link
Contributor Author

Happy New Year!
This commit might have removed your fixes. accessibility merge fix

@melloware
Copy link
Member

Yep it looks like a few changes have been lost during the accessibility merges. Will look today and see what else was lost

@melloware melloware reopened this Jan 8, 2024
@melloware melloware modified the milestones: 10.3.0, 10.3.1 Jan 8, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 8, 2024
@melloware
Fix primefaces#5640
b514752 
Fix primefaces#5556
Fix primefaces#5487
Fix primefaces#5457
Fix primefaces#5370
Fix primefaces#4051
@melloware melloware mentioned this issue Jan 8, 2024
Merged
@melloware melloware modified the milestones: 10.3.1, 10.4.0 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Milestone
10.3.1
2 participants
@melloware @sdwillbrand