Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: InputText does not immediately reflect locale changes #5535

Closed
Vloeck opened this issue Dec 6, 2023 · 0 comments · Fixed by #5538
Closed

Calendar: InputText does not immediately reflect locale changes #5535

Vloeck opened this issue Dec 6, 2023 · 0 comments · Fixed by #5538
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.0

Comments

@Vloeck
Copy link

Vloeck commented Dec 6, 2023

Describe the bug

When you change the locale of a Calendar widget, the InputText displaying the selected date does not change the format of the date and keeps the text as it was.
Only when you interact with the widget (e.g. focus the InputText) the formatted date gets changed.

Reproducer

https://codesandbox.io/p/sandbox/primereact-test-forked-2ng4vx

PrimeReact version

10.2.1

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

Firefox, Chrome

Steps to reproduce the behavior

  1. Select a date in Calendar widget
  2. Change locale for Calendar widget -> the InputText keeps the old formatted value
  3. Focus the InputText -> the InputText formats the date correctly now

Expected behavior

The InputText element of the Calendar widget should directly show the selected date formatted in the selected locale, not only on focus
@Vloeck Vloeck added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 6, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 6, 2023
@melloware melloware self-assigned this Dec 6, 2023
@melloware melloware added this to the 10.2.2 milestone Dec 6, 2023
melloware added a commit to melloware/primereact that referenced this issue Dec 6, 2023
@melloware
Fix primefaces#5535: Calendar update input on locale change
27f4bb0
@melloware melloware mentioned this issue Dec 6, 2023
Merged
melloware added a commit that referenced this issue Dec 6, 2023
@melloware
Fix #5535: Calendar update input on locale change (#5538)
67fbfa6
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5535: Calendar update input on locale change
2c9bdb6
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes2 (#5710)
24e22e0 
* Fix #5349: PanelMenu fix from PrimeVue

* Fix #5360: Cascade select popup not closing on escape

* fix: #5363, Mention: Page Breaks when navigating to Mention component

* fix: #5365 SplitButton popup not closing on escape button click

* Fix #5367: SpeedDial close on escape

* Fix #2666: Fix overlay components in cell editor

* Fix #5363: Mention better fix

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues

* Fix #5385: Password inputClassname missing

* Fix #5390: Calendar only render navigator in first month of multiple months

* Fix #5202: Calendar rendering performance increase

* Fix #5535: Calendar update input on locale change

* Fix #5533/#4147: Calendar respect viewDate

* Fix Calendar Input Docs

* fix:Calendar:currentView changed should invoke alignOverlay

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.0
Development

Successfully merging a pull request may close this issue.

Fix #5535: Calendar update input on locale change melloware/primereact
2 participants
@melloware @Vloeck