Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: image zoomed out when opening second time #5771

Closed
arnis87 opened this issue Jan 15, 2024 · 2 comments · Fixed by #5772
Closed

Image: image zoomed out when opening second time #5771

arnis87 opened this issue Jan 15, 2024 · 2 comments · Fixed by #5772
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.2

Comments

@arnis87
Copy link

arnis87 commented Jan 15, 2024

Describe the bug

When Image is opened second time it appears fully zoomed out, user needs to zoom in to see the image.

Reproducer

https://codesandbox.io/p/sandbox/pedantic-lalande-m8cyqx

PrimeReact version

10.3.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Open Image component
  2. Close the Image by clicking on mask/overlay
  3. Open second time
  4. Observe that image is not visible, it is actually zoomed out
  5. Press zoom in until image appears

Expected behavior

Image shown when opened second time
@arnis87 arnis87 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2024
@melloware melloware added this to the 10.4.0 milestone Jan 15, 2024
@melloware melloware self-assigned this Jan 15, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 15, 2024
@melloware
Fix primefaces#5771: Image mask click handling
0e1667d
@melloware melloware mentioned this issue Jan 15, 2024
Merged
melloware added a commit to melloware/primereact that referenced this issue Jan 15, 2024
@melloware
Fix primefaces#5771: Image mask click handling
9643586
melloware added a commit that referenced this issue Jan 15, 2024
@melloware
Fix #5771: Image mask click handling (#5772)
53de29b
@melloware
Copy link
Member

@arnis87 10.3.2 is out if you want to let me know how its working now.

@arnis87
Copy link
Author

arnis87 commented Jan 17, 2024

@melloware at least the reproducer now works. Will try it out in my actual application later. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.2
Development

Successfully merging a pull request may close this issue.

Fix #5771: Image mask click handling melloware/primereact
2 participants
@arnis87 @melloware