Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Virtual Scroller position resets upon lazy loaded #6015

Closed
hunghvu opened this issue Feb 19, 2024 · 3 comments · Fixed by #6017
Closed

DataTable: Virtual Scroller position resets upon lazy loaded #6015

hunghvu opened this issue Feb 19, 2024 · 3 comments · Fixed by #6017
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.5.2

Comments

@hunghvu
Copy link

hunghvu commented Feb 19, 2024

Describe the bug

Related to: primefaces/primevue#5078.

When an onLazyLoad event happens, the virtual scroller position moves back to the top. I saw the same report in PrimeVue, and upon a glance, it seems the fix has not been backported.

The behavior can be seen in the video below. The left side shows requests to load new data, and the right (edge of the screen), is scroller reset behavior.

2024-02-19.15-22-47.mp4

Reproducer

No response

PrimeReact version

10.5.1

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

Chrome v121.0.6167.184

Steps to reproduce the behavior

N/a (already a bug in PrimeVue)

Expected behavior

The virtual scroller should not be reset when onLazyLoad happens.
@hunghvu hunghvu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 19, 2024
@melloware
Copy link
Member

Can you link the PrimeVue ticket so I can see it?

@hunghvu hunghvu mentioned this issue Feb 19, 2024
Open
@hunghvu
Copy link
Author

hunghvu commented Feb 19, 2024

Can you link the PrimeVue ticket so I can see it?

Here you go: primefaces/primevue#5078
The commit that fixes this bug (supposedly): primefaces/primevue@3141f09

@melloware
Copy link
Member

Great I will take a look and backport it.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 19, 2024
@melloware melloware self-assigned this Feb 19, 2024
@melloware melloware added this to the 10.5.2 milestone Feb 19, 2024
melloware added a commit to melloware/primereact that referenced this issue Feb 20, 2024
@melloware
Fix primefaces#6015: VirtualScroll emty items defensive check
e80f95f
@melloware melloware mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.5.2
Development

Successfully merging a pull request may close this issue.

Fix #6015: VirtualScroll emty items defensive check melloware/primereact
2 participants
@melloware @hunghvu