Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Issue on selecting option using keyboard up/down/enter key when optionValue is provided. #6316

Closed
pradipjs opened this issue Apr 6, 2024 · 4 comments · Fixed by #6374, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Closed

Dropdown: Issue on selecting option using keyboard up/down/enter key when optionValue is provided. #6316

pradipjs opened this issue Apr 6, 2024 · 4 comments · Fixed by #6374, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Assignees
@shubhsaur
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@pradipjs
Copy link

pradipjs commented Apr 6, 2024 •
edited
Loading

Describe the bug

image
event.option is the value of the option. If we try to get the lable using just a value, it returns null and resets the dropdown to empty.
I think it should have whole option and in "if" condition we should match it using the getOptionValue function by passing the option. That would do the job.

Reproducer

https://stackblitz.com/edit/c8zt2t-9ncxnp?file=src%2FApp.jsx

PrimeReact version

10.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

Any

Steps to reproduce the behavior

Simple dropdown with optionValue parameter set.
Try to set value using. the keyboard, on foucs, press enter/tab to open the options. up/down arrow to move & enter to select the option.

Replication video : https://www.awesomescreenshot.com/video/26486438?key=8665b08a05cbc1611bbec00e4273ecb6

Expected behavior

It should select the option. It is currently resetting the dropdown.
@pradipjs pradipjs added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 6, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Needs Reproducer Issue needs a runnable reproducer and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Apr 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

Please fork the Stackblitz project and create a case demonstrating your bug report. This issue will be closed if no activities in 20 days.

@pradipjs
Copy link
Author

pradipjs commented Apr 9, 2024

I have updated the query with reproduce steps.
Here's the reference: https://stackblitz.com/edit/c8zt2t-9ncxnp?file=src%2FApp.jsx

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Reproducer Issue needs a runnable reproducer labels Apr 9, 2024
@melloware
Copy link
Member

Thanks changed it to "Bug"

shubhsaur pushed a commit to shubhsaur/primereact that referenced this issue Apr 10, 2024
Fix primefaces#6316: fixed issue on selecting option by key event whe…
8c1322d 
…n using optionValue prop
@shubhsaur shubhsaur mentioned this issue Apr 10, 2024
Merged
@shubhsaur
Copy link
Contributor

Hello @melloware, have submitted the PR for this issue

@melloware melloware added this to the 10.6.4 milestone Apr 13, 2024
melloware pushed a commit to shubhsaur/primereact that referenced this issue Apr 13, 2024
@melloware
Fix primefaces#6316: fixed issue on selecting option by key event whe…
1a957fc 
…n using optionValue prop
melloware added a commit that referenced this issue Apr 13, 2024
@shubhsaur @melloware
Fix #6316: fixed issue on selecting option by key event when using op…
943b454 
…tionValue prop (#6374)

* Fix #6316: fixed issue on selecting option by key event when using optionValue prop

* Update Dropdown.js

---------

Co-authored-by: Shubham Saurabh <shubhamsaurabh@Shubhams-MacBook-Pro.local>
Co-authored-by: Melloware <mellowaredev@gmail.com>
This was referenced May 21, 2024
Merged
Merged
@sja-cslab sja-cslab mentioned this issue Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhsaur shubhsaur

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
3 participants
@melloware @pradipjs @shubhsaur