Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar:Wrong components import in Headless Sidebar example #6353

Closed
ISNewton opened this issue Apr 9, 2024 · 1 comment · Fixed by #6354, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Closed

Sidebar:Wrong components import in Headless Sidebar example #6353

ISNewton opened this issue Apr 9, 2024 · 1 comment · Fixed by #6354, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Assignees
@melloware
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@ISNewton
Copy link
Contributor

ISNewton commented Apr 9, 2024

Describe the bug

The documentation example for the Headless Sidebar component in the PrimeReact documentation contains incorrect import statement statements for Ripple and StyleClass components.

Incorrect Imports

import { Ripple } from 'primereact/Ripple';
import { StyleClass } from 'primereact/StyleClass';

Correct Imports:

import { Ripple } from 'primereact/ripple';
import { StyleClass } from 'primereact/styleclass';

Reproducer

No response

PrimeReact version

10.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome and Firefox

Steps to reproduce the behavior

Copy the headless sidebar example into a react app and you will see the import errors

Expected behavior

No response
@ISNewton ISNewton added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 9, 2024
melloware added a commit to melloware/primereact that referenced this issue Apr 9, 2024
@melloware
Fix primefaces#6353: Sidebar doc fix
b7adb61
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
@melloware melloware self-assigned this Apr 9, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 9, 2024
@melloware melloware mentioned this issue Apr 9, 2024
Merged
melloware added a commit that referenced this issue Apr 9, 2024
@melloware
Fix #6353: Sidebar doc fix (#6354)
3da9641
@melloware
Copy link
Member

Thanks for reporting!

@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label Apr 30, 2024
This was referenced May 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
3 participants
@melloware @nitrogenous @ISNewton