Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currentPageReportTemplate property to Paginator #636

Closed
superhp opened this issue Nov 9, 2018 · 1 comment
Closed

Add currentPageReportTemplate property to Paginator #636

superhp opened this issue Nov 9, 2018 · 1 comment
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@superhp
Copy link

superhp commented Nov 9, 2018

I'm submitting an ...

[ ] bug report
[ ] feature request
[ ] support request 
[x] enhancement request 

for Paginator component https://www.primefaces.org/primereact/#/paginator

Current behavior
It is not possible to provide/change CurrentPageReport template which is currently hardcoded as '({currentPage} of {totalPages})'. This enhancement is needed for two cases: 1) when a different presentation way of current page report is needed, 2) when a site is multilingual and a word 'of' has to be translated.

Expected behavior
It should be possible to provide/change template by providing a new currentPageReportTemplate property to Paginator component like this:
<Paginator ... currentPageReportTemplate='({currentPage} of {totalPages})'>

superhp added a commit to superhp/primereact that referenced this issue Nov 9, 2018
@Merve7
Copy link
Contributor

Merve7 commented Nov 28, 2018

Thank you @superhp for your feedback and PR.

@Merve7 Merve7 self-assigned this Nov 28, 2018
@Merve7 Merve7 added the Type: New Feature Issue contains a new feature or new component request label Nov 28, 2018
@Merve7 Merve7 added this to the 2.0.0 milestone Nov 28, 2018
@Merve7 Merve7 closed this as completed in f4e96e5 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants