Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TriStateCheckbox: Upgrading to 10.6.3 with Tailwind theme breaks component #6405

Closed
gcko opened this issue Apr 17, 2024 · 0 comments · Fixed by #6406, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Closed

TriStateCheckbox: Upgrading to 10.6.3 with Tailwind theme breaks component #6405

gcko opened this issue Apr 17, 2024 · 0 comments · Fixed by #6406, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Assignees
@gcko
Labels
Component: Tailwind Tailwind specific issue Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@gcko
Copy link
Contributor

gcko commented Apr 17, 2024

Describe the bug

After updating PrimeReact from version 10.5.1 to 10.6.2 the TriStateCheckbox component is no longer properly styled and the styling breaks even more when clicked

It also shows a the checkbox input instead of the styled div container. Checking the checkbox makes it change its state.

This is an image of it prior to being selected
Screenshot 2024-04-16 at 16 06 38

This is an image of it after being selected the first time
Screenshot 2024-04-16 at 16 06 40

This is an image of it after being selected the second time
Screenshot 2024-04-16 at 16 06 42

This Can be demonstrated on the live documentation page: TriStateCheckbox > Theming > Unstyled

Reproducer

https://primereact.org/tristatecheckbox/#tailwind

PrimeReact version

10.6.3

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to the documentation page on version 10.6.2
  2. TriStateCheckbox > Theming > Unstyled > Tailwind
  3. Try clicking the checkbox to toggle its state
  4. Notice the visible checkbox

Expected behavior

The styling should be consistent with the default styled variant of the TriStateCheckbox component
@gcko gcko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 17, 2024
gcko added a commit to gcko/primereact that referenced this issue Apr 17, 2024
@gcko
fix: primefaces#6405 Fix Tailwind theme for TriStateCheckbox
01bb222 
- add missing `ptm('input')` to `inputProps` for use on the `input` Element. This aligns with other Primereact components
- Fix default tailwind styling in `tailwind/index.js`
- Update the tailwinddoc.js files for TriStateCheckbox
@gcko gcko mentioned this issue Apr 17, 2024
Merged
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 17, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 17, 2024
@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label Apr 30, 2024
This was referenced May 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcko gcko

Labels
Component: Tailwind Tailwind specific issue Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
3 participants
@gcko @melloware @nitrogenous