Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CascadeSelect: Typescript error in passthrough type definition #7016

Closed
ivanpajon opened this issue Aug 10, 2024 · 1 comment · Fixed by #7019 or #7020 · May be fixed by leoo1992/GeradorQRCode#95
Closed

CascadeSelect: Typescript error in passthrough type definition #7016

ivanpajon opened this issue Aug 10, 2024 · 1 comment · Fixed by #7019 or #7020 · May be fixed by leoo1992/GeradorQRCode#95
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.8.3

Comments

@ivanpajon
Copy link
Contributor

Describe the bug

Related to PR 6938

Reproducer

https://stackblitz.com/edit/vcfjtg?file=src%2Fmain.tsx

System Information

  • System:

OS: Windows 11 10.0.22631
CPU: (20) x64 12th Gen Intel(R) Core(TM) i9-12900HK
Memory: 33.95 GB / 63.71 GB

  • Binaries:

Node: 22.4.1 - ~\AppData\Local\nvs\default\node.EXE
npm: 10.8.1 - ~\AppData\Local\nvs\default\npm.CMD
pnpm: 9.6.0 - ~\AppData\Local\pnpm\pnpm.CMD

  • Browsers:

Edge: Chromium (127.0.2651.74)
Internet Explorer: 11.0.22621.3527

  • npmPackages:

react: 18.3.1 => 18.3.1

Steps to reproduce the behavior

  1. Go to reproducer
  2. Check comments in main.tsx and App.tsx

Expected behavior

CascadeSelect with proper types definitions and updated docs for unstyled mode
@ivanpajon ivanpajon added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 10, 2024
@melloware
Copy link
Member

I have to look but I believe the typescript is correct the Tailwind theme might be wrong.

@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 10, 2024
@melloware melloware self-assigned this Aug 10, 2024
@melloware melloware added this to the 10.8.3 milestone Aug 10, 2024
melloware added a commit to melloware/primereact that referenced this issue Aug 10, 2024
@melloware
Fix primefaces#7016: Revert CascadeSelect type for input
19c92bc
@melloware melloware mentioned this issue Aug 10, 2024
Merged
@ivanpajon ivanpajon mentioned this issue Aug 10, 2024
Merged
melloware pushed a commit that referenced this issue Aug 11, 2024
@ivanpajon
Fix #7016: CascadeSelect passthrough type definition and docs (#7020)
ca5b5e7 
* fix: CascadeSelect passthrough type definition

* fix: CascadeSelect unstyled theme doc
@leoo1992 leoo1992 mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.8.3
2 participants
@melloware @ivanpajon