Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add displayValueTemplate property to ProgressBar #978

Closed
NellyHaglund opened this issue Aug 5, 2019 · 2 comments · Fixed by #984
Closed

Add displayValueTemplate property to ProgressBar #978

NellyHaglund opened this issue Aug 5, 2019 · 2 comments · Fixed by #984
Assignees
@mertsincan
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
3.1.9

Comments

@NellyHaglund
Copy link
Contributor

I'm submitting a ...

[ ] bug report
[x ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
The value used to render progress in the progress bar is as well the value showed as label.
progress-bar-percentage-label

Expected behavior
Be able to have different display value than the actual value of the progress.
progess-bar-units-done-label

Senario:
You have a checklist of things to be done. The checklist contains 5 items, out of these 2 are currently done. The actual progress bar should be 40% filled, but display 2/5 as the displayed text value.
NellyHaglund pushed a commit to NellyHaglund/primereact that referenced this issue Aug 8, 2019
Add custom display value option in progress bar
e56ee5d 
Fixes primefaces#978
NellyHaglund pushed a commit to NellyHaglund/primereact that referenced this issue Aug 8, 2019
Add custom display value option in progress bar
774ebf0 
Fixes primefaces#978
@NellyHaglund NellyHaglund mentioned this issue Aug 8, 2019
Merged
NellyHaglund pushed a commit to NellyHaglund/primereact that referenced this issue Aug 8, 2019
Add custom display value option in progress bar
d8a21cd 
Fixes primefaces#978
mertsincan added a commit that referenced this issue Aug 27, 2019
@mertsincan
Merge pull request #984 from NellyHaglund/feature/ProgressBar-custom-…
d546a71 
…display-value

Fixed #978 - Add custom display value option in progress bar
@mertsincan mertsincan reopened this Aug 27, 2019
@mertsincan mertsincan self-assigned this Aug 27, 2019
@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label Aug 27, 2019
@mertsincan mertsincan added this to the 3.1.9 milestone Aug 27, 2019
@mertsincan mertsincan changed the title Add possibility to have different display value in ProgressBar Add displayValueTemplate property to ProgressBar Aug 27, 2019
@mertsincan
Copy link
Member

Hi @NellyHaglund,
Thanks a lot for the PR! I made some changes in it and added displayValueTemplate property to ProgressBar component. You can use it for this issue.

Best Regards,

@mertsincan
Copy link
Member

673189a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
3.1.9
Development

Successfully merging a pull request may close this issue.

Add custom display value option in progress bar NellyHaglund/primereact
2 participants
@NellyHaglund @mertsincan