Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier to standardize formatting #3173

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Conversation

melloware
Copy link
Member

###Defect Fixes
Add prettier to standardize formatting

@melloware
Copy link
Member Author

@mertsincan i know this is a big change but this is a huge improvement for the code base and it will enforce all the code looks the same. Once merged I will add npm run format-check to the Actions build to make sure it doesn't pass the build if someone has not run npm run format before pushing their PR.

@mertsincan mertsincan self-requested a review August 23, 2022 12:34
@mertsincan
Copy link
Member

mertsincan commented Aug 23, 2022

@melloware no problem! Good job ;)
Some Changes;

@melloware
Copy link
Member Author

melloware commented Aug 23, 2022

OK I updated with jsxSingleQuote: false and printWidth: 250 also added format-check to the npm run build command

@mertsincan
Copy link
Member

Nice! If it is OK for you, please merge it ;)

@melloware melloware merged commit a17ffa0 into primefaces:master Aug 23, 2022
@melloware melloware deleted the prettier branch August 23, 2022 13:23
@melloware melloware added this to the 8.5.0 milestone Aug 23, 2022
@kalinkrustev
Copy link
Contributor

kalinkrustev commented Aug 23, 2022

There is an extra semicolon here https://github.com/primefaces/primereact/blob/master/components/lib/dropdown/Dropdown.js#L621
It ends up in the rendered markup.
It came via 8da4b22.

@melloware
Copy link
Member Author

let me fix and make sure prettier isn't adding that!

@melloware
Copy link
Member Author

@kalinkrustev fixed! Thanks for reporting.

@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Core Team Issue or pull request has been *opened* by a member of Core Team labels Aug 23, 2022
@mertsincan mertsincan added Resolution: Needs Issue An issue needs to be created for the pull request and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Aug 26, 2022
@mertsincan mertsincan removed this from the 8.5.0 milestone Aug 26, 2022
@mertsincan mertsincan linked an issue Aug 26, 2022 that may be closed by this pull request
@mertsincan mertsincan removed the Resolution: Needs Issue An issue needs to be created for the pull request label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prettier to standardize formatting
3 participants