Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6095: Dialog refactor using FocusTrap #6435

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

melloware
Copy link
Member

Fix #6095: Dialog refactor using FocusTrap

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Apr 21, 2024
Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 1:38pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 1:38pm

@nitrogenous nitrogenous added the Status: Pending Test Issue or pull request is being tested by Core Team label Apr 25, 2024
Copy link
Member

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrogenous nitrogenous merged commit dbd2d33 into primefaces:master Apr 30, 2024
5 checks passed
@melloware melloware deleted the PR6095 branch April 30, 2024 11:32
@nitrogenous nitrogenous removed this from the 10.6.4 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Status: Pending Test Issue or pull request is being tested by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog: (accessibility) "display: none" inside dialog breaks focus tabbing
2 participants