Fix #6464: PrimeIcons v7 constants #6465
Conversation
melloware
added
the
Core Team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
| ARROW_CIRCLE_LEFT: 'pi .pi-arrow-circle-left', | ||
| ARROW_CIRCLE_RIGHT: 'pi .pi-arrow-circle-right', | ||
| ARROW_CIRCLE_UP: 'pi .pi-arrow-circle-up', | ||
| ARROW_DOWN_LEFTANDARROW_UP_RIGHT_TO_CENTER: 'pi .pi-arrow-down-left-and-arrow-up-right-to-center', |
There was a problem hiding this comment.
I think there are some missing underscores around "AND" here.
Also, I count 311 icons in the documentation – how come there are 314 entries here?
There was a problem hiding this comment.
@melloware It is "pi-circle-off", "pi-circle-on" and "pi-file-o" that are defined here but aren't listed in the documentation.
There was a problem hiding this comment.
I copied the names of the icons right from primeicons.css using regex and those values don't have underscores in the icon name so I kept them exact.
There was a problem hiding this comment.
"ARROW_UP_RIGHT_AND_ARROW_DOWN_LEFT_FROM_CENTER" does have underscores, though, and reads much nicer.
| WINDOW_MINIMIZE: 'pi pi-window-minimize', | ||
| WRENCH: 'pi pi-wrench', | ||
| YOUTUBE: 'pi pi-youtube' | ||
| ADDRESS_BOOK: 'pi .pi-address-book', |
There was a problem hiding this comment.
Uh, careful here! In the previous version, there was no period before the class name, but now there is.
There was a problem hiding this comment.
Ahh yeah I need to remove the period.
Fix #6464: PrimeIcons v7 constants