Added new capabilities and properties to Column and Dialog #6611
+49
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
melloware
requested changes
May 12, 2024
melloware
reviewed
May 12, 2024
|
Ok let me think about a better name for the prop then! |
|
Perfect, thanks! By the way, should I set onKeyDown event prevention to be done always and remove the Dialog property? |
|
Yes just default that on key down |
|
I just removed the property added to Dialog and now the onKeyDown propagation event is stoped by default. Also I restored back the Dialog api. |
melloware
requested changes
May 13, 2024
|
I've applied the remaining changes. Removed the unused property and changed the other one. It should be ready to go. |
|
@melloware I've removed a typo in BodyCell.js that formatter checker was preventing to merge the code. Hope now can pass the merge process... |
melloware
approved these changes
May 14, 2024
melloware
added
the
Status: Pending Test
|
Assigned to PrimeTek for review! |
|
Looks good! Superb |
nitrogenous
added
Type: Bug
nitrogenous
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some problmes with autocomplete component with dialog
Issue #6569