Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6058 Dropdown: Select value with Enter when optionValue is set #6703

Merged
merged 5 commits into from
May 29, 2024

Conversation

GabriellDatacamp
Copy link
Contributor

Fix #6058

When optionValue was set, and try to select the value with Enter key, the value is not selected.

In my correction, I saw that the selectItem function already has the getOptionValue function, making it unnecessary to call it within the onOptionSelect function.

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 2:28pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 2:28pm

@melloware

This comment was marked as outdated.

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label May 29, 2024
@melloware melloware merged commit c246fac into primefaces:master May 29, 2024
5 checks passed
@matthijsgroen
Copy link

This is quite a breaking change, when setting optionValue, normally you get a prop of an item object back in the onChange, now you always get the entire item. also setting the value using this optionValue is no longer working

@melloware
Copy link
Member

Copy link

@pradipjs pradipjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This created another issue when "optionValue" is provided. In this case, it started returning whole object instead of just a value of specific field provided in optionValue.

@dotnet22
Copy link

This created another issue when "optionValue" is provided. In this case, it started returning whole object instead of just a value of specific field provided in optionValue.

@melloware Yes, this is true. It created another bug. My entire app broke. Please help, as Dropdown is a very important component.

@melloware
Copy link
Member

OK all I reverted it here: #6885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Loses value if value changed via ENTER key
7 participants