Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-fix primefaces#6561: Return scalar values directly as a label for Dropdown #6872

Conversation

VytautasLozickas
Copy link
Contributor

@VytautasLozickas VytautasLozickas commented Jul 11, 2024

Fix #6858

While fixing #6858 (#6871) I apparently broke #6561 (Support for an array of simple values as options for Dropdown). This should fix it for good :)

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 0:40am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 0:40am

@melloware melloware merged commit 947b7d6 into primefaces:master Jul 11, 2024
7 checks passed
@melloware
Copy link
Member

@VytautasLozickas does this fix this one also: #6617

@VytautasLozickas
Copy link
Contributor Author

VytautasLozickas commented Jul 11, 2024

@melloware #6617 describes a bug where the value of 0 is handled incorrectly - I though haven't touched the handling of the actual option value, but when 0 is passed as a label it works just fine :)

@melloware
Copy link
Member

got it i see its the value not the label. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Object not valid when you use an Empty String ""
2 participants