Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6993: fix Editor bullet issue when using Quill 2.0.2 #7004

Merged

Conversation

swotiendang
Copy link
Contributor

@swotiendang swotiendang commented Aug 7, 2024

Defect Fixes

Fix #6993
Fix #6914

Feature Requests

Current Quill editor in primereact 10.8.2 use css of Quill 1.3.7 which is obsoleted in newer version, this fix is to demonstrate how original Editor works in primereact.

Screenshot
image

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 2:57pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 2:57pm

Copy link

github-actions bot commented Aug 7, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

1 similar comment
Copy link

github-actions bot commented Aug 7, 2024

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

actually @swotiendang they want you to copy quill Snow into that styles.css section so its CSS in JS and loaded as part of the component. Can you copy the CSS into that block for 2.0X?

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Aug 7, 2024
components/lib/editor/Editor.js Outdated Show resolved Hide resolved
@swotiendang
Copy link
Contributor Author

Do pay attention that this PR is quill snow original theme, I do not provide any modification for theme of primereact

components/lib/editor/EditorBase.js Outdated Show resolved Hide resolved
@melloware
Copy link
Member

I think PR has overrides already built into their themes on top of this SNOW theme. So I think your change is a good one.

@melloware melloware merged commit 0f10825 into primefaces:master Aug 7, 2024
5 checks passed
@swotiendang swotiendang deleted the bugfix/6993-Editor-bullet-issue branch August 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Listing as bullet display as numbered Editor: unordered list button creates ordered lists
2 participants