Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: add header position #7040

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

TikouWeb
Copy link
Contributor

@TikouWeb TikouWeb commented Aug 13, 2024

Fix #7025
New feature for stepper: customise header position

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 11:05am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 11:05am

@nitrogenous nitrogenous self-requested a review August 13, 2024 11:52
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 13, 2024
@nitrogenous
Copy link
Contributor

Thanks for the PR. We're trying to keep our library structures synced, so we'll check this core update and get back to you

@TikouWeb
Copy link
Contributor Author

@nitrogenous Noted, Thanks for reviewing it

Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrogenous
Copy link
Contributor

Your PR looks great! Thank you for your contribution. We would love to see more PRs from you in the future @TikouWeb

@nitrogenous nitrogenous merged commit 22374cc into primefaces:master Aug 21, 2024
5 checks passed
@TikouWeb
Copy link
Contributor Author

Nice to see a LGTM for my first open source contribution ever 😀.
Thank you! I'm glad the PR was helpful. I’d be happy to contribute more in the future ✌️

@melloware
Copy link
Member

@TikouWeb yes excellent job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Add label placement config in StepperPanel
3 participants