-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct passthrough (pt) implementation for Stepperpanel. #7069
Correct passthrough (pt) implementation for Stepperpanel. #7069
Conversation
…pper components to use mergeProps for pt attributes.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
cc @gcko for review |
can you also look at this one: #6758 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run npm run format
OK stepper unit tests are failing now because the HTML output has changed. |
I had to add/remove attributes in HTML elements like data-pc-section in few components or changing/removing the ptm so that it affects DOM of Stepper/StepperPanel. Do i have to update unit test as well? |
yeah you can run |
Sure! I was waiting for this PR to be merged. Now i can get started :) |
Thanks! |
@Sumeet-2023 i think we also need to update stepper.d.ts with the chnages in type styling for passthrough now too |
Maybe i dont think so we need changes in .d.ts file because i made changes in such a way that .d.ts file wont be affected for Stepper component. Or I might have misinterpreted what u wanted to convey. |
AHH yes I see you are right the TypeScript was correct the code was wrong! |
Ensured the pt (passthrough) mechanism properly applies Tailwind classes to the stepperpanel.
Example usage:
or
Defect Fixes
Fixes #6910