Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #6093 Fix Tailwind styles in unstyled mode #7124

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

gcko
Copy link
Contributor

@gcko gcko commented Sep 6, 2024

Defect Fixes #6093 Fix Tailwind styles in unstyled mode

  • Fix typos in tailwind style
  • Remove groupContainer and group styles. They are not needed
  • Fix panel styling
  • In Calendar.js: remove minWidth when in unstyled mode. Calling DomHandler.alignOverlay force sets minWidth, so we need to back it out. See Line 348
    static alignOverlay(overlay, target, appendTo, calculateMinWidth = true) {
        if (overlay && target) {
            if (appendTo === 'self') {
                this.relativePosition(overlay, target);
            } else {
                // This line causes the issue
                calculateMinWidth && (overlay.style.minWidth = DomHandler.getOuterWidth(target) + 'px');
                this.absolutePosition(overlay, target);
            }
        }
    }

- Fix typos in tailwind style
- Remove `groupContainer` and `group` styles. They are not needed
- Fix panel styling
- In Calendar.js: remove minWidth when in unstyled mode. Calling `DomHandler.alignOverlay` force sets `minWidth`, so we need to back it out. See [Line 348](https://github.com/primefaces/primereact/blob/master/components/lib/utils/DomHandler.js#L348)
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 6:02am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 6:02am

@melloware melloware merged commit 692524b into primefaces:master Sep 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar (Tailwind): Width is calculated wrong
2 participants