feat: make AdditionalProps argument in IconOptions type optional #7149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
1 similar comment
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
approved these changes
Sep 10, 2024
melloware
added
the
Typescript
|
Thanks! |
alperari
deleted the
feat/icon-options-make-additional-props-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Requests
Description
When switching from PrimeReact
v9.6.3tov10.8.2, i had to do some migrations due to the feature introduced by #4642.Also, i noticed the inconsistency among the code in
utils.d.ts, i.e.AdditionalPropsargument is defined to be optional in some places. Yet, I believe,IconOptionswas missed out.This PR makes the
AdditionalPropsargument for the typeIconOptionsoptional, so that you don't get the following TypeScript error:P.S. This relates to a closed issue #4639 and I'm not sure whether to create new one.