You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR fixes accessibility issue of dropdown: Accessibility users were able to navigate through dropdown but screen reader won't read labels of dropdown options making component unusable.
It was happening because dropdown options were not focusable, and focused element were not actually attempting to focus on targeted element. So, by focusing them using manually upon triggering onFocus element function fixed the problem.
Additionally, introduced additional accessibility attributes that would improve explanation of dropdown options aria-setsize, aria-posinset. Inspiration came from primeng/dropdown component.
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
melloware
added
the
Component: Accessibility
Defect Fixes
Fixes: #6030
PR fixes accessibility issue of dropdown: Accessibility users were able to navigate through dropdown but screen reader won't read labels of dropdown options making component unusable.
It was happening because dropdown options were not focusable, and focused element were not actually attempting to focus on targeted element. So, by focusing them using manually upon triggering onFocus element function fixed the problem.
Additionally, introduced additional accessibility attributes that would improve explanation of dropdown options
aria-setsize,aria-posinset. Inspiration came from primeng/dropdown component.