Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7196: Remove unnecessary timeout for opening overlay in MultiSelect #7197

Merged

Conversation

iamkyrylo
Copy link
Contributor

@iamkyrylo iamkyrylo commented Sep 17, 2024

Fixes #7196

Demo:

Screen.Recording.2024-09-17.at.19.17.39.1.mov

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 4:17pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 4:17pm

@iamkyrylo iamkyrylo force-pushed the fix/bug-with-timeout-in-multiselect branch from c84d37d to 6ab4312 Compare September 17, 2024 09:15
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 17, 2024
@melloware
Copy link
Member

Can you test the original scenario for overlayVisible i have a feeling it is not working now with this fix.

@melloware melloware merged commit 3718fad into primefaces:master Sep 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening overlay with timeout causes unexpected behavior during testing components with MultiSelect
2 participants