Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Multiselect): optimize handling of grouped options by flattening structure #7357

Merged
merged 2 commits into from
Oct 19, 2024
Merged

fix(Multiselect): optimize handling of grouped options by flattening structure #7357

merged 2 commits into from
Oct 19, 2024

Conversation

KumJungMin
Copy link
Contributor

Defect Fixes


How to Resolve

  • Based on the reference code, the structure of the group options was modified to a flattened structure.

Issue Description

  • A. When focusing on an item in the first group, the focus class is also applied to items in the another group.
  • B. When move using down arrow key and press Enter, I can not select items within the group.

Test

A. Focus check

  • Before
스크린샷 2024-10-19 오후 2 55 25
  • After
스크린샷 2024-10-19 오후 2 54 44



B. Arrow keys + Enter to select group items

  • Before
2024-10-19.3.03.10.mov

  • After
2024-10-19.3.03.35.mov

@vercel Vercel
Copy link

vercel bot commented Oct 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2024 6:06am
primereact-v9 ⬜️ Ignored (Inspect) Oct 19, 2024 6:06am

@melloware melloware merged commit d9e35ad into primefaces:master Oct 19, 2024
6 checks passed
@KumJungMin KumJungMin deleted the fix/issue-6678 branch October 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiselect: All items at the same index in a group are marked focused
2 participants
@KumJungMin @melloware