Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad type for column field when fn is used #1078

Closed
harveylee opened this issue Mar 13, 2021 · 0 comments
Closed

Bad type for column field when fn is used #1078

harveylee opened this issue Mar 13, 2021 · 0 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.5.0

Comments

@harveylee
Copy link
Contributor

Could the field property for Column in DataTable and other similar components have type [ String, Function ] and TypeScript definition string | ((item: any) => any)?

FWIW passing a Function into field already seems to work, but Vue complains with a warning that the prop type is incorrect.

Related to #647 and #681
@cagataycivici cagataycivici changed the title Could DataTable Column "field" property also accept Function? Bad type for column field when fn is used May 10, 2021
@cagataycivici cagataycivici added this to the 3.4.1 milestone May 10, 2021
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working priority - medium labels May 10, 2021
@cagataycivici cagataycivici self-assigned this May 10, 2021
This was referenced Feb 3, 2022
Closed
Merged
tugcekucukoglu pushed a commit that referenced this issue Feb 11, 2022
@harveylee @tugcekucukoglu
Add Function to Column prop field types
77dfce1 
To match the Typescript types added in #1078 and not trigger Vue's "Invalid prop" warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@cagataycivici @harveylee