Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog header not visible #179

Closed
fairking opened this issue Jan 31, 2020 · 4 comments
Closed

Dialog header not visible #179

fairking opened this issue Jan 31, 2020 · 4 comments
Assignees
@mertsincan
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
1.0.3

Comments

@fairking
Copy link

fairking commented Jan 31, 2020 •
edited
Loading

After introducing the scroll: #153, #145 .
Would be nice to show the dialog header with the close button always on top:
image
@mertsincan mertsincan self-assigned this Jan 31, 2020
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 31, 2020
@mertsincan mertsincan added this to the 1.0.3 milestone Jan 31, 2020
@mertsincan
Copy link
Member

Thanks a lot for the screenshot. Fixed for next version.

@mertsincan mertsincan mentioned this issue Jan 31, 2020
Closed
@fairking
Copy link
Author

@mertsincan I always glad to help you with the testing guys.

mertsincan added a commit that referenced this issue Feb 3, 2020
@mertsincan
Refactor #179
d41c339
@cagataycivici
Copy link
Member

There is a live demo for long content now;

https://www.primefaces.org/primevue/#/dialog

@fairking
Copy link
Author

fairking commented Feb 7, 2020

Thanks a lot guys for your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
3 participants
@cagataycivici @mertsincan @fairking