Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeedDial: Invalid aria-controls value being set in list items #6221

Closed
mvl22 opened this issue Aug 12, 2024 · 2 comments
Closed

SpeedDial: Invalid aria-controls value being set in list items #6221

mvl22 opened this issue Aug 12, 2024 · 2 comments
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mvl22
Copy link

mvl22 commented Aug 12, 2024

Describe the bug

We are seeing a Lighthouse report complaining about invalid aria-controls values, as shown in the screenshot below.

I think this is because each list item is being given an id + _list value, but there is no 'Controlling element' with that ID value, at this point in the code:

https://github.com/primefaces/primevue/blob/master/packages/primevue/src/speeddial/SpeedDial.vue#L31C22-L31C35

(Is aria-controls actually needed here given that these are native list items in a native HTML list?)

By contrast, the Button is correctly associated with the id of the menu, implemented at line 9, so I don't think there is any problem with that.

Although this is in PrimeVue 3, I think the same will happen in v. 4, looking at the source.

aria-controls

Reproducer

later, if necessary

PrimeVue version

3.43.0

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

All

Steps to reproduce the behavior

Create a element, and observe the generated HTML using the Inspector. With the Lighthouse plugin installed, switch to the tab, and generate a report.

Expected behavior

There should not be an '[aria-*] attributes do not have valid values' section generated.

@mvl22 mvl22 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 12, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 23, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.5 milestone Aug 23, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 23, 2024
@tugcekucukoglu tugcekucukoglu added the Component: Accessibility Issue or pull request is related to WCAG or ARIA label Aug 23, 2024
@mvl22
Copy link
Author

mvl22 commented Aug 23, 2024

Thanks so much.

Can this be kindly tagged to the v3 branch also, if 3.x releases are still happening?

LeaderbotX400 pushed a commit to LeaderbotX400/primevue that referenced this issue Aug 29, 2024
@mvl22
Copy link
Author

mvl22 commented Dec 1, 2024

I confirm we are seeing this resolved in our application, having upgraded to primevue v4. The Lighthouse report no longer mentions this problem.

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants