Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4113: Calendar showMonthAfterYear locale option #4114

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

melloware
Copy link
Member

@melloware melloware commented Jul 9, 2023

Fix #4113: Calendar showMonthAfterYear locale option

@cetincakiroglu @tugcekucukoglu As you can tell I don't know PrimeVue but I took my best shot at making it just like PrimeReact. I don't know if there is a better way to conditionally render in Vue.

@vercel
Copy link

vercel bot commented Jul 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2023 11:43am

@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 5, 2023
@mertsincan mertsincan added this to the 3.33.1 milestone Sep 5, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.33.1, 3.33.2 Sep 5, 2023
@tugcekucukoglu
Copy link
Member

Thanks a lot for your contribution! But, this PR is outdated! Could you please update it? Then, I'll review it asap.

@melloware
Copy link
Member Author

Conflicts resolved!

@tugcekucukoglu tugcekucukoglu merged commit 81d971e into primefaces:master Sep 5, 2023
@tugcekucukoglu
Copy link
Member

Only a small change was required.

<template> element is a kind of invisible element for conditional rendering for Vue.

Thanks for your contribution!

@tugcekucukoglu tugcekucukoglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 5, 2023
@melloware melloware deleted the PV4113 branch September 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar: showMonthAfterYear IL8N setting (from PrimeReact/PrimeFaces)
3 participants