Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing default labels in ConfirmDialog and ConfirmPopup #6077

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

m-kutnik
Copy link
Contributor

Defect Fixes

Fixes #6075

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 1:25pm
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 1:25pm

@m-kutnik
Copy link
Contributor Author

Offtopic question: How do you guys run unit tests in the project? I noticed there is no Vite/Vitest/Jest configuration in primevue package, so I just run them with my local Vitest setup to make sure they pass - but it seems there is no easy way to do that out-of-the-box while contributing

@tugcekucukoglu tugcekucukoglu merged commit d697f82 into primefaces:master Jul 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfirmDialog and ConfirmPopup: Missing accept/reject labels
2 participants