Fix: Trigger outsideClickListener in capture phase to handle stopPropagation #7233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agation This commit addresses the issue where the overlay in components does not hide when clicking outside the component, if the click event is stopped using stopPropagation on an element or its parents. The solution changes the event listener for detecting outside clicks to be triggered in the capture phase instead of the bubbling phase. This ensures that the outside click is correctly detected even if stopPropagation is called.
4 tasks
|
Deployment failed with the following error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue where the overlay in components does not hide when clicking outside the component, if the click event is stopped using stopPropagation on an element or its parents.
The solution changes the event listener for detecting outside clicks to be triggered in the capture phase instead of the bubbling phase. This ensures that the outside click is correctly detected even if stopPropagation is called.
Fix #7234