Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fastlane + github workflow for building example app #2

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Add fastlane + github workflow for building example app #2

merged 7 commits into from
Jan 8, 2024

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Jan 3, 2024 •
edited
Loading

  • Adds parameterised github workflow for building example apps
  • Bonus: fixes issue with selected card network type

@jnewc jnewc added the do not merge When there's (external) reason to not merge the PR label Jan 3, 2024
@jnewc
Copy link
Contributor Author

jnewc commented Jan 3, 2024

Functional, but won't pass until the feature/co-badged-cards is merged in primer-io/primer-sdk-ios

@jnewc jnewc removed the do not merge When there's (external) reason to not merge the PR label Jan 8, 2024
@jnewc jnewc requested a review from NQuinn27 January 8, 2024 10:48
@NQuinn27
Copy link

NQuinn27 commented Jan 8, 2024

LGTM just the one comment

@jnewc jnewc merged commit 087bc94 into jn/co-badged-cards-example Jan 8, 2024
1 check passed
@jnewc jnewc deleted the jn/co-badged-cards/workflows branch January 8, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NQuinn27 NQuinn27 NQuinn27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnewc @NQuinn27