Bring cachingEnabled check outside barrier

primer-io · Oct 2, 2024 · 6572eab · 6572eab
1 parent 9444f84
commit 6572eab
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Sources/PrimerSDK/Classes/Core/Cache/ConfigurationCache/ConfigurationCache.swift b/Sources/PrimerSDK/Classes/Core/Cache/ConfigurationCache/ConfigurationCache.swift
@@ -22,9 +22,9 @@ class ConfigurationCache: ConfigurationCaching {
  }
 
  func data(forKey key: String) -> ConfigurationCachedData? {
- Self.queue.sync(flags: .barrier) { [weak self] in
-  guard let self = self,
-  cachingEnabled else {
+ guard cachingEnabled else { return nil }
+ return Self.queue.sync(flags: .barrier) { [weak self] in
+ guard let self = self else {
  return nil
  }
  if let cachedData = cache.value(forKey: key) {
@@ -39,8 +39,9 @@ class ConfigurationCache: ConfigurationCaching {
  }
 
  func setData(_ data: ConfigurationCachedData, forKey key: String) {
- Self.queue.sync(flags: .barrier) { [weak self] in
- guard let self = self, cachingEnabled else {
+ guard cachingEnabled else { return }
+ return Self.queue.sync(flags: .barrier) { [weak self] in
+ guard let self = self else {
  return
  }
  // Cache includes at most one cached configuration