Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apple Pay EC Updates #1004

Merged
merged 11 commits into from
Oct 2, 2024
Merged

fix: Apple Pay EC Updates #1004

merged 11 commits into from
Oct 2, 2024

Conversation

NQuinn27
Copy link
Contributor

@NQuinn27 NQuinn27 commented Sep 27, 2024 •
edited
Loading

Final tweaks for Apple Pay Express Checkout:

  • Remove the shipping method name from the lineItems display.
  • Align errors
  • Adds Shipping to PrimerOrder object
Screenshot 2024-09-27 at 12 16 35

Updates the Debug App to allow more granular testing of Apple Pay Shipping controls
Screenshot 2024-09-27 at 12 15 08

@NQuinn27 NQuinn27 requested a review from a team as a code owner September 27, 2024 10:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

Warnings
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.
⚠️

Sources/PrimerSDK/Classes/Data Models/API/PaymentAPIModel.swift#L100 - Lines should not have trailing whitespace. (trailing_whitespace)
⚠️

Sources/PrimerSDK/Classes/Data Models/API/PaymentAPIModel.swift#L136 - Line should be 150 characters or less: currently 173 characters (line_length)
⚠️

Sources/PrimerSDK/Classes/Data Models/API/PaymentAPIModel.swift#L154 - Lines should not have trailing whitespace. (trailing_whitespace)
⚠️

Sources/PrimerSDK/Classes/Data Models/API/PaymentAPIModel.swift#L413 - File should contain 400 lines or less: currently contains 413 (file_length)
⚠️

Sources/PrimerSDK/Classes/Data Models/_PaymentAPIModel.swift#L24 - Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
⚠️

Sources/PrimerSDK/Classes/Data Models/_PaymentAPIModel.swift#L24 - Lines should not have trailing whitespace. (trailing_whitespace)

Generated by 🚫 Danger Swift against 2a5fce6

semirp
semirp previously approved these changes Sep 27, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Appetize link: https://appetize.io/app/efmkihegnbc7cyzpeczwesk6ge

@NQuinn27
Copy link
Contributor Author

NQuinn27 commented Oct 2, 2024

@semirp latest commit adds Shipping to PrimerOrder

@semirp semirp self-requested a review October 2, 2024 09:23
semirp
semirp previously approved these changes Oct 2, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NQuinn27 NQuinn27 merged commit 012167b into master Oct 2, 2024
14 checks passed
@NQuinn27 NQuinn27 deleted the nq/granular_applepay_testing branch October 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnewc jnewc jnewc approved these changes

@semirp semirp semirp approved these changes

@borisprimer borisprimer Awaiting requested review from borisprimer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NQuinn27 @jnewc @semirp