Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove optionalDependencies in favor of wasm-node package #421

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

joshblack
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: fd1419a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/behaviors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack marked this pull request as ready for review July 29, 2024 21:32
@joshblack joshblack requested a review from a team as a code owner July 29, 2024 21:32
@@ -94,8 +95,5 @@
"rollup": "^4.18.0",
"size-limit": "^11.1.4",
"typescript": "^5.2.2"
},
"optionalDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this super quickly!!

@keithamus keithamus merged commit 2efcb3f into main Aug 1, 2024
7 checks passed
@keithamus keithamus deleted the chore/remove-optional-rollup-deps branch August 1, 2024 10:24
@primer-css primer-css mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants