Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI upgrades #856

Merged
merged 16 commits into from
Dec 11, 2024
Merged

CI upgrades #856

merged 16 commits into from
Dec 11, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Dec 10, 2024

Summary

Fixes and upgrades various CI workflows, some of which were failing and preventing us from accurately tracking regressions.

List of notable changes:

  • Fixed failing create-react-app integration test
  • Fixed failing next-js integration test
  • Upgraded Playwright for VRT to use latest Docker image
  • Use chromium instead of chrome for running Playwright on ARM CPUs
  • Nuked and regenerated 486 (all) previous visual snapshots
  • VRT now passing green all the time
  • Playwright reports now correctly uploaded and downloadable
  • Upgrade Node version to 20 for all workflows

What should reviewers focus on?

  • Check all CI tests pass
  • Review the visual diffs for any unexpected changes

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Passing VRT:
Screenshot 2024-12-11 at 13 51 28

Passing Next.js tests:
Screenshot 2024-12-11 at 13 51 21

Playwright reports now downloadable:
Screenshot 2024-12-11 at 13 51 07

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 343cdbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 10, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Dec 10, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah requested a review from danielguillan December 11, 2024 13:49
Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! 🎉

@rezrah rezrah merged commit 8732b70 into main Dec 11, 2024
17 checks passed
@rezrah rezrah deleted the rezrah/fix-ci-integration-tests-dec-10-24 branch December 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants