Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust spacing in river breakout #883

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Jan 8, 2025

Summary

Closes #873
Part of https://github.com/github/primer/issues/4601

🔗 Storybook preview

List of notable changes:

  • Reduced spacing between the main text and link in River Breakout component
  • Applied a maximum width to the main text in River Breakout component
  • Replaced Container with a wider Grid component decorator to be more representative of real-world usage

What should reviewers focus on?

  • Review design changes are correct

Steps to test:

  1. Storybook example

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
Screenshot 2025-01-08 at 12 44 39 Screenshot 2025-01-08 at 13 18 52

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: cf0166e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🔍 Design token changes found

View CSS variable changes
+ --brand-River-spacing-innerY: var(--base-size-24);
+ --brand-River-spacing-innerY: var(--base-size-24);
+ --brand-River-spacing-innerY: var(--base-size-32);

"value": "var(--base-size-24)"
},
"1280px": {
"value": "var(--base-size-32)"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielguillan @jesussandreas For breakout vertical spacing, i only have a reference point for desktop. Left mobile and tablets at 24px as before. Let me know if you feel it should also change.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modification request] Adjust River Breakout spacing
1 participant