-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust spacing in river breakout #883
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: cf0166e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes+ --brand-River-spacing-innerY: var(--base-size-24); + --brand-River-spacing-innerY: var(--base-size-24); + --brand-River-spacing-innerY: var(--base-size-32); |
"value": "var(--base-size-24)" | ||
}, | ||
"1280px": { | ||
"value": "var(--base-size-32)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielguillan @jesussandreas For breakout vertical spacing, i only have a reference point for desktop. Left mobile and tablets at 24px as before. Let me know if you feel it should also change.
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
Summary
Closes #873
Part of https://github.com/github/primer/issues/4601
🔗 Storybook preview
List of notable changes:
What should reviewers focus on?
Steps to test:
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: