Add anti-aliasing to Text and other components #884
+125
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #871
Part of https://github.com/github/primer/issues/4601
Follow up to #482
Adds targeted
font-smooth
toText
and other components in dark mode.Important
Applying blanket AA on websites using font-smooth is NOT recommended due to missing web standards
It's also not recommended to use it anywhere except dark mode.
We will only apply AA when:
light
orextralight
variants, due to poor legibility16px
List of notable changes:
What should reviewers focus on?
Steps to test:
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: