Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remix integration test #886

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix remix integration test #886

merged 2 commits into from
Jan 9, 2025

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Jan 9, 2025

Summary

Fixes Remix integration test

For posterity, it was failing because the latest version of the CLI automatically initalized git in a sub directory and attempted to make an initial commit but without an active SSH agent this isn't possible inside a GitHub action.

Fixed by removing git initialization, which isn't necessary in an ephemeral end-to-end test.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🟢 No design token changes found

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 3ab7cc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah marked this pull request as ready for review January 9, 2025 16:35
@rezrah rezrah merged commit 6b73869 into main Jan 9, 2025
16 of 17 checks passed
@rezrah rezrah deleted the rezrah/remix-fix-int-test-9-jan branch January 9, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant