Merge pull request #1045 from primer/next-1

More "component refresh" tweaks
primer · Mar 11, 2020 · 0e52ad3 · 0e52ad3
2 parents 20f243c + c80466c
commit 0e52ad3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/src/labels/mixins.scss b/src/labels/mixins.scss
@@ -8,7 +8,7 @@
   display: inline-block;
   padding: 0 7px;
   font-size: $font-size-small;
-  font-weight: $font-weight-semibold;
+  font-weight: $font-weight-normal;
   line-height: 18px;
   border: $border-width $border-style transparent;
   border-radius: 2em;

diff --git a/src/navigation/menu.scss b/src/navigation/menu.scss
@@ -50,7 +50,7 @@
   &[aria-current] {
     cursor: default;
     // stylelint-disable-next-line primer/colors
-    background-color: $orange-000;
+    background-color: #fff2f0; // custom coral
 
     &::before {
       position: absolute;
@@ -60,7 +60,7 @@
       width: 2px;
       content: "";
       // stylelint-disable-next-line primer/colors
-      background-color: $orange-500;
+      background-color: #f9826c; // custom coral
     }
   }
 

diff --git a/src/navigation/sidenav.scss b/src/navigation/sidenav.scss
@@ -62,7 +62,7 @@
   // Bar on the left
   &::before {
     // stylelint-disable-next-line primer/colors
-    background-color: $orange-500;
+    background-color: #f9826c; // custom coral
   }
 }
 

diff --git a/src/navigation/underline-nav.scss b/src/navigation/underline-nav.scss
@@ -21,21 +21,22 @@
   background-color: transparent;
   border: 0;
   // stylelint-disable-next-line primer/borders
-  border-bottom: 2px $border-style transparent;
+  border-bottom: 2px $border-style rgba($border-gray-dark, 0);
   transition: border-bottom-color 0.36s ease-in;
 
   &:hover,
   &:focus {
     text-decoration: none;
     border-bottom-color: $border-gray-dark;
-    transition: border-bottom-color 0.12s ease-out;
+    transition-timing-function: ease-out;
+    transition-duration: 0.12s;
   }
 
   &.selected,
   &[role=tab][aria-selected=true],
   &[aria-current] {
     // stylelint-disable-next-line primer/borders
-    border-bottom-color: $orange-500;
+    border-bottom-color: #f9826c; // custom coral
   }
 }