Merge pull request #33 from primer/fix-links

Link cleanup
primer · Oct 3, 2018 · 5c78c92 · 5c78c92
2 parents 4fa9488 + 63bf857
commit 5c78c92
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 19 deletions.
diff --git a/src/Hero.js b/src/Hero.js
@@ -16,18 +16,18 @@ const Hero = props => (
           <Heading color="blue.4" mb={2} fontSize={[48, 56, 84]} fontWeight='bold'>Primer</Heading>
           <Text color="blue.2" fontSize={[4,5,5,7]} lineHeight={1.25}>Resources, tooling, and design guidelines for building interfaces with GitHub’s design system</Text>
           <Text is="p" color="blue.3" mt={4} className="text-mono">
-          <LinkLight fontSize={[0,1,2]}
-            href='https://styleguide.github.com/primer/'>
-            Style guide
-          </LinkLight> ・
-          <LinkLight ml={2} fontSize={[0,1,2]}
-            href='https://spectrum.chat/primer'>
-            Community
-          </LinkLight> ・
-          <LinkLight ml={2} fontSize={[0,1,2]}
-            href='https://github.com/primer/'>
-            Open-source
-          </LinkLight>
+            <LinkLight fontSize={[0,1,2]}
+              href='https://styleguide.github.com/primer/'>
+              Style guide
+            </LinkLight> ・
+            <LinkLight ml={2} fontSize={[0,1,2]}
+              href='https://spectrum.chat/primer'>
+              Community
+            </LinkLight> ・
+            <LinkLight ml={2} fontSize={[0,1,2]}
+              href='https://github.com/primer/'>
+              Open-source
+            </LinkLight>
           </Text>
         </Box>
       </Box>

diff --git a/src/LinkDark.js b/src/LinkDark.js
@@ -1,4 +1,4 @@
-// Extends Link from primer/components to make color primitives available, as well as fontSize and space which should be added in primer/components. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this.
+// Extends Link from primer/components to make color primitives available. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this.
 
 import {Link} from '@primer/components'
 import {
@@ -13,8 +13,6 @@ const LinkDark = styled(Link)`
   &:hover {
     color: ${props => props.theme.colors.gray[8]};
   }
-  ${fontSize}
-  ${fontWeight}
 `
 
 export default LinkDark
diff --git a/src/LinkLight.js b/src/LinkLight.js
@@ -1,4 +1,4 @@
-// Extends Link from primer/components to make color primitives available, as well as fontSize and space which should be added in primer/components. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this.
+// Extends Link from primer/components to make color primitives available. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this.
 
 import {Link} from '@primer/components'
 import {
@@ -9,7 +9,6 @@ import styled from 'react-emotion'
 
 const LinkLight = styled(Link)`
   color: ${props => props.theme.colors.blue[3]} !important;
-  ${fontSize}
 `
 
 LinkLight.defaultProps = {

diff --git a/src/LinkPromo.js b/src/LinkPromo.js
@@ -1,4 +1,4 @@
-// Extends Link from primer/components to make color primitives available, as well as fontSize and space which should be added in primer/components. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this.
+// Extends Link from primer/components to make color primitives available. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this.
 
 import {Link} from '@primer/components'
 import {
@@ -9,7 +9,6 @@ import styled from 'react-emotion'
 
 const LinkPromo = styled(Link)`
   color: ${props => props.theme.colors.orange[3]} !important;
-  ${fontSize}
 `
 
 export default LinkPromo