Skip to content

Commit

Permalink
479-user-pics-misaligned-in-issues-assignment-view (#2242)
Browse files Browse the repository at this point in the history
* 479-user-pics-misaligned-in-issues-assignment-view

* Update avatar-stack.scss

- Not last child means that each stacking avatar would remove the border-right which is necessary to stack correctly. The presentational order is right to left not left to right.

* Create smooth-crabs-protect.md

* Update avatar-stack.scss

- Fixed pointer to the anchor element

* Update .changeset/smooth-crabs-protect.md

- removed branch name from changeset

Co-authored-by: Jon Rohan <yes@jonrohan.codes>

Co-authored-by: Jon Rohan <yes@jonrohan.codes>
  • Loading branch information
JoshBowdenConcepts and jonrohan authored Sep 7, 2022
1 parent cbc0d32 commit ef31fd9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/smooth-crabs-protect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
---

This border change was made to ensure that assignee avatars would stack next to one another correctly.
8 changes: 6 additions & 2 deletions src/avatars/avatar-stack.scss
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
// stylelint-enable selector-max-type

// Account for 4+ avatars
&:nth-child(n+4) {
&:nth-child(n + 4) {
display: none;
opacity: 0;
}
Expand All @@ -68,7 +68,7 @@
margin-right: 3px;
}

.avatar:nth-child(n+4) {
.avatar:nth-child(n + 4) {
display: flex;
opacity: 1;
}
Expand Down Expand Up @@ -118,6 +118,10 @@
// stylelint-disable-next-line primer/spacing
margin-left: 3px;
}

.avatar:not(:last-child) {
border-left: 0;
}
}

.avatar.avatar-more {
Expand Down

0 comments on commit ef31fd9

Please sign in to comment.