Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offset-* classes don't have !important #576

Closed
sophshep opened this issue Oct 12, 2018 · 1 comment
Closed

offset-* classes don't have !important #576

sophshep opened this issue Oct 12, 2018 · 1 comment
Labels
patch release

Comments

@sophshep
Copy link

sophshep commented Oct 12, 2018 •
edited
Loading

I recently tried to override mx-auto with an offset class and I couldn't, because mx-auto has !important, but offset- doesn't: https://github.com/primer/primer/blob/master/modules/primer-layout/lib/grid-offset.scss

giphy
@skullface
Copy link
Contributor

perfect gif

@sophshep sophshep mentioned this issue Oct 15, 2018
Closed
@shawnbot shawnbot changed the title Add !important to Offset classes offset-* classes don't have !important Oct 17, 2018
@sophshep sophshep mentioned this issue Oct 17, 2018
Merged
@shawnbot shawnbot mentioned this issue Oct 17, 2018
Merged
@simurai simurai closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shawnbot @skullface @simurai @sophshep and others