Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add !important to grid offset classes #578

Closed
wants to merge 2 commits into from

Conversation

sophshep
Copy link

As outlined in this issue, I recently tried to override mx-auto with an offset class and I couldn't, because mx-auto has !important, but offset- doesn't. This PR fixes that.

(Fixes #576)

/cc @primer/ds-core

@shawnbot
Copy link
Contributor

@sophshep Thank you for this! Would you mind re-doing it with #545's responsive-variants as the base branch?

@shawnbot shawnbot changed the base branch from master to release-11.0.0 October 17, 2018 20:47
@shawnbot shawnbot requested a review from a team October 17, 2018 20:48
@sophshep
Copy link
Author

Would you mind re-doing it with #545's responsive-variants as the base branch?

👍 Closing this in favor of #582

@sophshep sophshep closed this Oct 17, 2018
@sophshep sophshep deleted the offset-is-important branch October 17, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants