-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primer CSS Header Illustration #630
Comments
I dig the composition and the implementation of the new style ✨, just a few questions and feedback:
Overall though I think this looks great and is a nice compliment to the components illustration. Looking forward to seeing these all looking consistent in future. This also reminded me we should have a thumbnail illustration for the readme when the new site is published—can't remember if we discussed that but I'll add it to the tracking issue. |
Nice!! My 2 cents-
|
@broccolini @emilybrick Thanks for the feedback!!! I've listed my answers to your questions below:
|
Here are a few more variations to the header illustration. Original VersionRevisionsGlobal changes: Muted v2v3v4 |
Love the progress on these. Personally, v4 feels the strongest for me. Love the movement of the line. Subdued 'Aa' is definitely feeling better. Only nitpick, and this is pretty subjective: These are all feeling strong though, so I'm curious, of these, which one feels the best to you? |
Final version of header image in this figma file: |
First pass at the header illustration for Primer CSS. I included the Components header for reference but keep in mind that the Components header still uses styles prior to the standardization started during the README project.
CC @broccolini @emilybrick
The text was updated successfully, but these errors were encountered: