docs: add Ash's new header illustration #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @emplums: I started with a verbatim copy of the header from primer/components, but after introducing the global primer CSS it looks like I've had to set fontSize={2} explicitly on all of our links to bump it back up. The way I did this feels kinda yucky; would you have done it differently?
shawnbot
changed the title
shawnbot
commented
Jan 9, 2019
| @@ -91,7 +90,7 @@ const SectionLink = withRouter(({href, router, ...rest}) => ( | |||
| */ | |||
| const NavLink = withRouter(({href, router, ...rest}) => { | |||
| return ( | |||
| <Box mb={2}> | |||
| <Box mt={2}> | |||
There was a problem hiding this comment.
/cc @broccolini @emplums The spacing on primer/components is 3, but I bumped this back down to 2 because it seemed a bit too spacious. (Also, the top margin collapses with the <SectionLink mb={3}> so that there isn't an extra 2x whitespace at the bottom of the lists to account for the section's padding. ✨ )
shawnbot
commented
Jan 9, 2019
| @@ -2,4 +2,4 @@ export const WCAG_AA = 4.5 | |||
| export const WCAG_AAA = 7 | |||
| export const MIN_CONTRAST_RATIO = WCAG_AAA | |||
|
|
|||
| export const CONTENT_MAX_WIDTH = 932 | |||
| export const CONTENT_MAX_WIDTH = 1012 | |||
There was a problem hiding this comment.
This matches the width={1012} from primer/components' IndexHero.
This was referenced Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the intro text on the landing page with @ashygee's new image from #630 and starts to get the hero area and header looking more like Primer Components. I've also matched the side nav width and spacing so that it's easier to do apples-to-apples comparisons between the two. 🔍
Before
After
Primer Components (for reference)